Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IEEE test #8320

Merged
merged 2 commits into from
Dec 11, 2021
Merged

Fix IEEE test #8320

merged 2 commits into from
Dec 11, 2021

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Dec 11, 2021 •
edited
Loading

Bypass SSL Verification in URLDownload
It was only set when JabRef was started normally

Fixes #8305

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr
Fix IEEE test
e13d84e 
Bypass SSL Verificaiton in URlDownload
It was only set when JabRef was started normally
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 11, 2021
@Siedlerchr
Copy link
Member Author

Remaining failing test is ACM #8259

@calixtus calixtus merged commit 42fb85c into main Dec 11, 2021
@calixtus calixtus deleted the fixIEE branch December 11, 2021 19:29
Siedlerchr added a commit that referenced this pull request Dec 12, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/main'
dd2afac 
* upstream/main:
  New translations JabRef_en.properties (Turkish) (#8321)
  snap: Remove superfluous files post build (#8319)
  Fix IEEE test (#8320)
  New translations JabRef_en.properties (German) (#8318)
  Fixed exception handling (#8314)
Siedlerchr added a commit that referenced this pull request Dec 12, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into tinylog
d86bcfe 
* upstream/main:
  New translations JabRef_en.properties (Turkish) (#8321)
  snap: Remove superfluous files post build (#8319)
  Fix IEEE test (#8320)
  New translations JabRef_en.properties (German) (#8318)
  Fixed exception handling (#8314)
  New Crowdin updates (#8312)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix IEEE test
2 participants
@Siedlerchr @calixtus